gui(intsaller): ping electrum backend both with tcp & ssl #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I won't comment on the technical solution, but on the UI side I would use yellow/orange (the usual warning color) for warnings. I would possibly make it a little bigger |
|
pythcoiner
force-pushed
the
ping_electrum
branch
from
53170ef
to
4944837
Compare
|
|
|
Do we need to warn about SSL if people are using on their local network? |
|
Wouldn't it be simpler to have a "Use SSL" checkbox? |
|
the advantage of ping both is i guess almost the time our user will not know what is ssl, so w/ this solution they don't have to care about. |
i think it's not easy to be sure wether we are a local network or not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a double ping (both tcp & ssl) when defining an electrum server address.
After ping if the prefix is not ssl we display a warning to the user: